Include inference time in --trace-compile-timing
#59220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--trace-compile` log only reports compilation triggers / entrypoints, not all compilation units, so it's important for this measurement to include indirect compilation (not just "self" time)
nsajko
added
the
observability
NHDaly
reviewed
Aug 21, 2025
KristofferC
pushed a commit
that referenced
this pull request
Sep 1, 2025
It's important for this measurement to include indirect compilation (not just "self" time), since the `--trace-compile` log only reports compilation triggers / entrypoints (not all compiled code). (cherry picked from commit 888c2c3)
KristofferC
pushed a commit
that referenced
this pull request
Sep 2, 2025
It's important for this measurement to include indirect compilation (not just "self" time), since the `--trace-compile` log only reports compilation triggers / entrypoints (not all compiled code). (cherry picked from commit 888c2c3)
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Sep 15, 2025
It's important for this measurement to include indirect compilation (not just "self" time), since the `--trace-compile` log only reports compilation triggers / entrypoints (not all compiled code). (cherry picked from commit 888c2c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important for this measurement to include indirect compilation (not just "self" time), since the
--trace-compilelog only reports compilation triggers / entrypoints (not all compiled code).